[Webkit-unassigned] [Bug 28623] svn-[un]apply should change directories to the repository root before [un]applying

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 21 14:16:41 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=28623





--- Comment #6 from Peter Kasting <pkasting at google.com>  2009-08-21 14:16:41 PDT ---
(In reply to comment #4)
> Either way, I don't think I could write this and provide a reliable patch
> without testing.  pkasting, are you still using svn?

Yes... I was hoping to avoid diving back into the WebKitTools directory :/

It seems like the right fix is to modify the code that applies individual diffs
to change to the right directory, apply the diff, and then change back.  Then
no extra global state or preprocessing is required.

A simple version of "the right directory" is to just move to the repository
root, while a more complex one would be to try each directory on the way up the
chain from the current directory.  This second method would make
subtree-relative patches work too.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list