[Webkit-unassigned] [Bug 28623] svn-[un]apply should change directories to the repository root before [un]applying

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 21 14:09:22 PDT 2009


--- Comment #4 from Joseph Pecoraro <joepeck at webkit.org>  2009-08-21 14:09:21 PDT ---
(In reply to comment #2)
> Created an attachment (id=38392)
 --> (https://bugs.webkit.org/attachment.cgi?id=38392) [details]

Now that I've thought about it some more, since the patches to un-apply are
provided on the command line relative to where the script is originally run,
then changing the directory as early as I had done in this patch will likely
not find the file (otherwise you'd be applying from the svnRoot anyways).

I can think of a few solutions:
  - store the result of chdirReturningRelativePath() and use it when grabbing
the command line arguments.
  - or, starting by storing the absolute paths of all the command line
arguments, then proceeding to change directory and apply the patches per usual.

Either way, I don't think I could write this and provide a reliable patch
without testing.  pkasting, are you still using svn?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list