[Webkit-unassigned] [Bug 28241] Media controls panel does not have a volume control slider

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28241





--- Comment #3 from Eric Carlson <eric.carlson at apple.com>  2009-08-21 13:58:49 PDT ---
> +void RenderMedia::updateVolumeSliderContainer(bool visible) {

Brace should be on a new line


> +    } else if (!visible) {
> +        m_volumeSliderContainer->setVisible(false);
> +        m_volumeSlider->update();
> +    }

Why call setVisible(false) if it is already not visible?


>  void RenderMedia::forwardEvent(Event* event)
>  {
>      if (event->isMouseEvent() && m_controlsShadowRoot) {
>          MouseEvent* mouseEvent = static_cast<MouseEvent*>(event);
>          IntPoint point(mouseEvent->absoluteLocation());
> -        if (m_muteButton && m_muteButton->hitTest(point))
> +        bool showVolumeSlider = false;

This breaks the current mute button. Why don't you use a compile switch
for the new code so ports can opt into when they are ready.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.