[Webkit-unassigned] [Bug 22249] CSS Multicolumn text is split awkwardly

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=22249





--- Comment #20 from Eric Seidel <eric at webkit.org>  2009-08-21 09:52:07 PDT ---
(From update of attachment 35028)
"split" not "splitted":
+        from being splitted into different columns.

(unless that's british english that I don't know...)

I'm confused why this talks about original and uses minimum:
41     if (minimumColumnHeight >= 0) {
 3842         // If originalColHeight was too small, we need to try to layout
again.
 3843         return layoutColumns(endOfContent, minimumColumnHeight);
 3844     }

Seems like this could use a comment:
3756     if (computeIntrinsicHeight) {
 3757         if (requestedColumnHeight < 0)
 3758             colHeight += columnSlop;
 3759         else
 3760             colHeight = requestedColumnHeight;
 3761     }
 3762     int originalColHeight = colHeight;
Also, it's strange to see "original" being set after modification.  I think I'm
just not familiar with this code.

I think you should try to track dhyatt down on irc and ask him nicely to review
this small patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.