[Webkit-unassigned] [Bug 21248] Support placeholder on textarea

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=21248


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34534|review?                     |review+, commit-queue+
               Flag|                            |




--- Comment #13 from Eric Seidel <eric at webkit.org>  2009-08-21 09:47:05 PDT ---
(From update of attachment 34534)
This looks great.  I'm just sad we can's share implementations:

+    static void dispatchFocusEvent(InputElement*, Element*);
+    static void dispatchBlurEvent(InputElement*, Element*);
+    static bool placeholderShouldBeVisible(const InputElement*, const
Element*);
+    static void updatePlaceholderVisibility(InputElement*, Element*, bool
placeholderValueChanged = false);

We could put those on HTMLFormControlElement... or on a new
HTMLTextControlElement subclass.  Or on some class which both of these used
(since "having" placeholder text does not necessarily mean you need to "be" a
classs which can have placehodler text.  We could use 'has a' instead of 'is a'
to share code.)

I'm going to approve this as is.  I would like you to consider a follow-up
patch to share more of this code.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.