[Webkit-unassigned] [Bug 27256] Geolocation timeout parameter is not correctly applied

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27256





--- Comment #3 from Eric Seidel <eric at webkit.org>  2009-08-20 13:41:17 PDT ---
(From update of attachment 34970)
Why are tests impossible?  (I'm not suggesting they aren't, I just need more
info as to 'why?')

Is it possible that the handlers could do nasty things?
 65         m_errorCallback->handleEvent(error.get());

like start a new request or something?  Anything that could potentially crash
us when we return back to executing c++ after the JS callback?

We only name arguments when they add clarity:
 88         GeoNotifier(Geolocation* geolocation, PassRefPtr<PositionCallback>,
PassRefPtr<PositionErrorCallback>, PassRefPtr<PositionOptions>);
 115     void requestTimedOut(GeoNotifier* notifier);

I'm know next-to-nothing about this code.  What you've posted looks sane.  Are
there other webkit reviewers who know something about geolocation?  Who uses
this code?  Andriod?  Does iPhone use this or do they have their own thing?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.