[Webkit-unassigned] [Bug 28498] Replace many manually-released CFTypeRefs with RetainPtrs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28498





--- Comment #3 from mitz at webkit.org  2009-08-20 12:23:33 PDT ---
(In reply to comment #2)
> (From update of attachment 35214 [details])
> Yay!
> 
> +    static CGColorSpaceRef colorSpace = CGColorSpaceCreateDeviceRGB();
> 
> static instead of RetainPtr here? Is this an expensive call or something?

It’s not prohibitively expensive (Core Graphics has its own static shared
instance), but I figured I would save the extra layers of function calls and
retain count churn.

Thanks for the review!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.