[Webkit-unassigned] [Bug 28495] Give WebKit clients access to the window features specified in window.open

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28495


Adam Roben (aroben) <aroben at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35212|                            |review?
               Flag|                            |




--- Comment #1 from Adam Roben (aroben) <aroben at apple.com>  2009-08-20 11:14:04 PDT ---
Created an attachment (id=35212)
 --> (https://bugs.webkit.org/attachment.cgi?id=35212)
Give WebKit clients access to the window features specified in window.open

Reviewed by NOBODY (OOPS!).

Need a short description and bug URL (OOPS!)

* COMVariantSetter.h: Added COMVariantSetters for bool and float.

* Interfaces/IWebUIDelegatePrivate.idl: Added IWebUIDelegatePrivate2,
which contains a new version of createWebViewWithRequest that also
passes the window features as an IPropertyBag. This is analagous to
the -createWebViewWithRequest:windowFeatures: method added to
WebUIDelegate on Mac in r27452. Also added key strings for use with
the window features property bag.

* WebCoreSupport/WebChromeClient.cpp:
(createWindowFeaturesPropertyBag): Added this helper function to turn
a WebCore::WindowFeatures into an IPropertyBag for passing to WebKit
clients.
(WebChromeClient::createWindow): If the UI delegate implements
IWebUIDelegatePrivate2, call the new createWebViewWithRequest function
that takes a window features property bag. If the delegate doesn't
implement the new function, fall back to the old functions.
---
 4 files changed, 120 insertions(+), 0 deletions(-)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.