[Webkit-unassigned] [Bug 28037] SocketStreamHandle interface for WebSocket API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28037


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35115|review?                     |review-
               Flag|                            |




--- Comment #12 from Alexey Proskuryakov <ap at webkit.org>  2009-08-19 17:25:07 PDT ---
(From update of attachment 35115)
> diff --git a/WebCore/platform/network/cf/SocketStreamHandle.h b/WebCore/platform/network/cf/SocketStreamHandle.h
<...>
> +        KURL m_url;
> +
> +        // platform specific data
> +        friend class SocketStreamHandleInternal;
> +        OwnPtr<SocketStreamHandleInternal> internal;

All data in this file is platform specific, cross-platform data goes to
SocketStreamHandleBase. So, there is no need for SocketStreamHandleInternal any
more.

Everything else looks good to me, but this is something that's best to fix
before landing, so r-.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.