[Webkit-unassigned] [Bug 27889] [Chromium] RTL autocomplete popup is not layout correctly.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27889





--- Comment #25 from Jeremy Moskovich <playmobil at google.com>  2009-08-19 16:52:11 PDT ---
(From update of attachment 34585)
Really, really great work on this - a few minor comments.

> @@ -75,7 +76,10 @@ static const PopupContainerSettings drop
>      true, // focusOnShow
>      true, // setTextOnIndexChange
>      true, // acceptOnAbandon
> -    false // loopSelectionNavigation
> +    false, // loopSelectionNavigation
> +    false,  // restrictWidthOfListBox
Please align the comments with the ones above.

> @@ -817,25 +821,32 @@ void PopupListBox::paintRow(GraphicsCont
> +    // FIXME: http://b/1210481 We should get the padding of individual option
While you're here, could you change this to point at a bug on the public
tracker?


> @@ -87,6 +91,27 @@ namespace WebCore {
> +        // Wheter restrict the width of the PopupListBox or not. We restrict
Perhaps:
"""
Should we restrict the width of the PopupListBox?
Autocomplete popups are restricted, combo-boxes (select tags) aren't.
"""
> +        // We could either display the items in the drop-down using its DOM element's
> +        // directionality, or we could display the items in the drop-down using heuristics:
could->can
> +        // https://bugs.webkit.org/show_bug.cgi?id=27889 for detail.
details

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.