[Webkit-unassigned] [Bug 27967] Decouple the code that deals with the main DB and quota management from the rest of the DB code

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27967





--- Comment #33 from Michael Nordman <michaeln at google.com>  2009-08-19 15:47:42 PDT ---
(In reply to comment #32)
> The problem was that we used a RefPtr copy of a SecurityOrigin (that was
> destroyed as soon as we were out of its scope) instead of using the original
> pointer in SQLTransactionClient::didCommitTransaction().

Right... so we traded a threading bug for a refcounting bug... ooops.

I wish bugzilla let me view just the diffs between the previous patch and this
new one? Just did so with a text diff tool on the old an new patch files.

Your change lgtm.

> We should probably add a Database::securityOrigin() method and explain in more
> details when to use securityOrigin() and when to use securityOriginCopy().
> Right now, it is not obvious at all what the difference is, and it's very
> tempting to call m_database->securityOriginCopy() instead of
> m_database->document()->securityOrigin().

Agreed that something could be done to improve on this. SecurityOrigin has a
thread safe refcount, but the underlying object is not thread safe. This is a
fragile situation? I think think addressing that situation is probably
out-of-scope for this fix.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.