[Webkit-unassigned] [Bug 28269] Inspector: Improve Cookie DataGrid to Show Hidden Data

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 19 13:50:00 PDT 2009


--- Comment #29 from Joseph Pecoraro <joepeck02 at gmail.com>  2009-08-19 13:49:58 PDT ---
(In reply to comment #27)
> This looks so much better from the InspectorController interaction perspective.

Hehe, for me this felt like more work jumping between multiple files with
duplication.  But, at least there is no specific bindings, so it works
immediately with v8.

> domAgent has private mainFrameDocument() method.

Done. Can't believe I missed that.

> not sure if WebKit source base allows casts - leaving for Timothy's advice

Waiting for comment.

> Here and in other places: I try to maintain same order of methods in .h and
> .cpp

Done. I reordered all my new functions such that if the function comes after X
the header, it comes after X in the implementation.

> > +void InspectorFrontend::didGetCookies(int callId, const ScriptArray& cookies)
> > +void InspectorFrontend::didGetCookies(int callId, const String& cookiesString)
> There is no overloading in JavaScript, while InspectorFrontend is supposed to
> reflect the JavaScript API. I'd either call these differently, or if you are
> bound to a single name due the callback nature, I would use didGetCookies(int,
> String, ScriptArray) signature and get rid of extra
> boolean flag. In javascript it would be if (cookies) { good code } else  {
> fallback(cookiesString); }

Done. I did keep the boolean when it actually gets to the CookieItemsView
rather then inspecting the Cookie Data itself.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list