[Webkit-unassigned] [Bug 27543] Add platform/wince/ files for WINCE port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27543





--- Comment #69 from Eric Seidel <eric at webkit.org>  2009-08-19 00:14:37 PDT ---
(From update of attachment 34376)
Does this not exist anywhere else in teh code base?
// stableRound rounds -0.5 to 0, where lround rounds -0.5 to -1.
 41 static inline int stableRound(double d)
 42 {

The ChnageLog is pretty bare.

What does the "c" mean here?  (they're not const)  Are you sure these follow
WebKit style?
static int cHorizontalWidth[] = { 15, 11 };
 61 static int cHorizontalHeight[] = { 15, 11 };

I would look up the size and have a single setFrameRec call:
     if (orientation == VerticalScrollbar)
 79         setFrameRect(IntRect(0, 0, cVerticalWidth[controlSize()],
cVerticalHeight[controlSize()]));
 80     else
 81         setFrameRect(IntRect(0, 0, cHorizontalWidth[controlSize()],
cHorizontalHeight[controlSize()]));

Also that would allow you to use IntRect(IntPoint(), scrollbarSize) constructor
as well.

Indent:
     default:
 126         {
 127             IntRect beforeThumbRect, thumbRect, afterThumbRect;
 128             splitTrack(trackRect(), beforeThumbRect, thumbRect,
afterThumbRect);
 129             if (part == BackTrackPart)

Early return is preferred:
    if (enabled != isEnabled()) {
 164         Scrollbar::setEnabled(enabled);

this really should have its own bug, and this bug should be retired.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.