[Webkit-unassigned] [Bug 15743] run-webkit-tests hangs when WebCore tries to log too much

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=15743


David Kilzer (ddkilzer) <ddkilzer at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35086|review?                     |review+
               Flag|                            |




--- Comment #11 from David Kilzer (ddkilzer) <ddkilzer at webkit.org>  2009-08-18 18:02:00 PDT ---
(From update of attachment 35086)
> +    my $actualRead = readFromDumpToolWithTimer(IN, ERROR);

Now that $errorRead doesn't exist, it might be nice to rename this to
$readResults, for example.

> +            if ($haveSeenEofIn && $haveSeenEofError) {
>                  last;
>              }

This could be written in a single line as:

    last if $haveSeenEofIn and $haveSeenEofError;

Neither of the above two changes are required, though.

r=me!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.