[Webkit-unassigned] [Bug 28441] New: build error with ICU 4.2.x on Windows + Visual studio

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28441

           Summary: build error with ICU 4.2.x on Windows + Visual studio
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Windows XP
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Web Template Framework
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: jshin at chromium.org
                CC: mrowe at apple.com, pkasting at google.com


When I tried to build Chromium with ICU 4.2.x on Windows, I came across exactly
the same error as Peter encountered a couple of month ago (
http://paste.lisp.org/display/81781 ) except that I'm getting it in
wtf/unicode/icu/CollatorICU.cpp. 

He fixed the problem by  using Vector<char> instead of std::string.  (
http://trac.webkit.org/changeset/44643 ). 

In this case, I'm afraid that's not an option because unicode/ucol.h pulls in
unicode/unistr.h, which in turn pulls in unicode/std_string.h and <string>. On
Windows, <string> pulls in <xlocale> with tolower, toupper, etc. They're all
replaced with
WTF_Please_use_ASCIICType_instead_of_ctype_see_comment_in_ASCIICType_h leading
to compile errors (multiple declarations).

One work around the problem is to append "_foo" to
WTF_Please_use_ASCIICType_instead_of_ctype_see_comment_in_ASCIICType_h for
'foo' #defined in DisallowCType.h

So, they'll look like:

#define tolower
WTF_Please_use_ASCIICType_instead_of_ctype_see_comment_in_ASCIICType_h_tolower
#define toupper
WTF_Please_use_ASCIICType_instead_of_ctype_see_comment_in_ASCIICType_h_toupper

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.