[Webkit-unassigned] [Bug 28019] WINCE PORT: modified files in WebCore/storage

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28019





--- Comment #11 from Laszlo Gombos <laszlo.1.gombos at nokia.com>  2009-08-18 13:00:15 PDT ---
(In reply to comment #10)
> (In reply to comment #8)
> > (From update of attachment 34135 [details] [details])
> > Well, I don't know what this change is doing from the ChangeLog.  I assume
> > you're trying to make it possible to run Database operations on the main
> > thread?
> > 
> > Redirecting to a platform-specific header is generally never the right
> > approach:
> > #if PLATFORM(WINCE)
> >  35 
> >  36 #include "wince/DatabaseThreadWince.h"
> >  37 
> >  38 #else
> > 
> > The abstraction (whatever you're trying to do there) likely belongs at a
> > different/higher level.  It would be bad, for example if 5 ports all had
> > redirects there.
> 
> Platform-independent webkit code could always work with single-threaded
> application. But the storage/database implemenation broke that. It forces using
> multiple threads. But threading is expensive on some platforms or is unwanted
> by some products.
> 
> Our patch is single-threaded solution. If other ports or products want use this
> solution, we can change the name from "Wince" to "SingleThreaded".


QtWebKit has a build time flag called ENABLE_SINGLE_THREADED to turn off
ENABLE_JSC_MULTIPLE_THREADS and WebCore features that create additional
threads. I'm interested to make this feature available for QtWebKit (and maybe
other ports) as well, not just to the WINCE port. See
http://trac.webkit.org/changeset/44411.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.