[Webkit-unassigned] [Bug 28421] bugzilla-tool landed a change in the wrong directory

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 17 23:27:14 PDT 2009


--- Comment #1 from Eric Seidel <eric at webkit.org>  2009-08-17 23:27:13 PDT ---
I totally agree!  Just not sure what to do here.

The tool which is doing the "wrong" thing here is actually svn-apply, which is
happy to accept the patch which bugzilla-tool gives it and apply it.

Some possible solutions I could think of:
1.  svn-create-patch could be changed to add explicit information about
directory adds.  Right now svn-apply infers directory adds from file adds.
2.  svn-apply (or bugzilla-tool) could be changed to try and match directory
paths against known existing directory paths and fail when they look too
3.  svn-apply could be given a white-list of known top-level directories.

All of these solutions would just be teaching svn-apply/bugzilla-tool to "fail"
when it encounters these sorts of patches.

I don't think that we should be making efforts to support patches from
sub-directories.  But I do think that we should have some minimal safe-guards
in place to prevent sub-directory patches from causing havoc.

I suggest we implement #3 above, as it's the simplest.  I'm interested in your
thoughts on the matter.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list