[Webkit-unassigned] [Bug 28271] V8 Bindings for Desktop Notifications

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28271


Dimitri Glazkov (Google) <dglazkov at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34764|review?                     |review-
               Flag|                            |




--- Comment #8 from Dimitri Glazkov (Google) <dglazkov at chromium.org>  2009-08-17 18:18:12 PDT ---
(From update of attachment 34764)
Overall, looks good. Some style nits around abbreviations:

> +    Notification* notif = V8DOMWrapper::convertToNativeObject<Notification>(V8ClassIndex::NOTIFICATION, args.Holder());

notification

> +    Notification* notif = V8DOMWrapper::convertToNativeObject<Notification>(V8ClassIndex::NOTIFICATION, args.Holder());

notification

> +    NotificationCenter* notifInterface = V8DOMWrapper::convertToNativeObject<NotificationCenter>(V8ClassIndex::NOTIFICATIONCENTER, args.Holder());

notificationCenter

> +    RefPtr<V8CustomVoidCallback> callback;
> +    if (args.Length() > 0) {
> +        if (!args[0]->IsObject()) {
> +            V8Proxy::throwError(V8Proxy::TypeError, "Callback must be of valid type.");
> +            return v8::Undefined();

return throwError("Callback must...");

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.