[Webkit-unassigned] [Bug 28303] [Qt] XSLT support with QtXmlPatterns

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28303


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34854|review?                     |review-
               Flag|                            |




--- Comment #15 from Eric Seidel <eric at webkit.org>  2009-08-17 17:45:21 PDT ---
(From update of attachment 34854)
Seems we could have a better abstraction here:
#if ENABLE(XSLT)
 310 #if ENABLE(XSLT) && !USE(QXMLQUERY)
311311     , m_transformSource(0)
312312 #endif

Style.  Likewise, we need a better abstraction:
 #if USE(QXMLQUERY)
 3757 void Document::setTransformSource(const String &source)
 3758 {
 3759     m_transformSource = source;
 3760 }
 3761 #else

If that means having a TransformSource class which is opaque to document,
that's fine.

Abstraction/cleanup needed:
 #if ENABLE(XSLT)
 183 #if ENABLE(XSLT) && !USE(QXMLQUERY)
184184 void* xmlDocPtrForString(DocLoader*, const String& source, const String&
url);
185185 #endif

Yeah, basically all of the:
 44 #if ENABLE(XSLT) && !USE(QXMLQUERY)
look wrong.  Or at least they could be done better with just a little bit of
abstraction work.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.