[Webkit-unassigned] [Bug 28268] adjustLineToPixelBoundaries used in platform/GraphicsContext drawLine needs refactoring finished.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28268


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34865|review?                     |review-
               Flag|                            |




--- Comment #26 from Eric Seidel <eric at webkit.org>  2009-08-17 16:42:36 PDT ---
(From update of attachment 34865)
These functions should be something like "patternOffsetForDashes" and
"patternWidthForDashes" or similarly longer/clearer names.  Then you can use
ful names like "patternOffset" instead of "patOffset" for the locals.

I was at first confused as to what these functions were for until I realized
they only applied to the line decoration/stroke style code paths.

Otherwise the patch looks good.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.