[Webkit-unassigned] [Bug 27967] Decouple the code that deals with the main DB and quota management from the rest of the DB code

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27967





--- Comment #13 from Michael Nordman <michaeln at google.com>  2009-08-17 14:03:17 PDT ---
(In reply to comment #12)

This lgtm, but you need a webkit reviewer.

> added ASSERTs in the .cpp file

Thank you.

> > void didCommitTransaction(...);  // for databaseChanged
> > void didExecuteStatement(...);  // for databaseSizeChanged
> > bool didExceedQuota(...);  // for databaseExceedsQuota
> 
> changed.

Ah... much more webkitty ;)

> this seems to be the only accessor for getting the origin from a Database
> object. we could probably introduce a new accessor (or replace the existing
> one), but i wouldn't want to do this before talking to the authors of this code
> and understanding why they had a copying accessor here in the first place.

I see, it looks like this may have to do with thread safety. The class is
refcounted but not a thread safe refcount.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.