[Webkit-unassigned] [Bug 28254] [Chromium] Remove legacy code in "WebCore/platform/chromium/PopupMenuChromium.cpp"

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Aug 16 21:26:39 PDT 2009


--- Comment #6 from Hironori Bono <hbono at chromium.org>  2009-08-16 21:26:38 PDT ---
(In reply to comment #5)
> (From update of attachment 34825 [details])
> This bug is resolved.  No need for this patch to be marked for review.

Sorry for my stupid question in advance.
I would like to clarify whether or not it is good to send a change that only
includes layout tests since I'm writing some layout tests to replace some part
of manual tests with them.
As I written in my previous comments, this issue is fixed by a change for Bug
28205. But it uses a manual test because it is not easy to write a layout test
which verifies Bug 28205. On the other hand, this issue can be verified with a
simple layout test. So, I would like to add this layout test to lessen the
dependency to manual tests even though this doesn't include any code changes.
Personally, either is fine for me whether or not to add the attached layout
test. Nevertheless, I would like to clarify it to prevent annoying reviewers
with my stupid changes that only include layout tests.


Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list