[Webkit-unassigned] [Bug 28335] HTML5 media elements do not fire waiting events correctly

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28335


Albert J. Wong <ajwong at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34889|                            |review?
               Flag|                            |




--- Comment #3 from Albert J. Wong <ajwong at chromium.org>  2009-08-15 00:19:24 PDT ---
Created an attachment (id=34889)
 --> (https://bugs.webkit.org/attachment.cgi?id=34889)
waiting/seeked fix

the seeked event is missed due when the ready state is changed during
a seek.

Patch by Albert Wong <ajwong at chromium.org> on 2009-08-15
Reviewed by NOBODY (OOPS!).

HTML5 media elements do not fire waiting events correctly
https://bugs.webkit.org/show_bug.cgi?id=28335

The video-seeking.html test does not need to be updated because
it uses a local file which never fires a waiting/seeking event.
To test waiting/seeking, a source that doesn't buffer fully too
quickly is required.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::setReadyState): add support for
waiting event when seeking.
(WebCore::HTMLMediaElement::finishSeek): send seeked event
whenever seeking finishes.
(WebCore::HTMLMediaElement::mediaPlayerTimeChanged): dispatch to
new function.
* html/HTMLMediaElement.h:
---
 3 files changed, 50 insertions(+), 12 deletions(-)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.