[Webkit-unassigned] [Bug 28304] S60 Qt Webkit browser crashes while loading the V8 Benchmark Suite

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28304


Oliver Hunt <oliver at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34839|review?                     |review-
               Flag|                            |




--- Comment #3 from Oliver Hunt <oliver at apple.com>  2009-08-14 15:24:57 PDT ---
(From update of attachment 34839)
The Interpreter should not have any platform specific code in it.

In general if your patch adds #if PLATFORM(...) to code where there are no
existing PLATFORM specific #ifs, your patch is wrong.

I'm also unsure why you feel the need to do this here -- there are plenty of
places where you can just check for malloc failure and convert to a JS OOM
exception.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.