[Webkit-unassigned] [Bug 28310] Chromium: Show a "Mute Disabled" button on audio error.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28310


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34864|review?                     |review-
               Flag|                            |




--- Comment #2 from Eric Seidel <eric at webkit.org>  2009-08-14 15:14:18 PDT ---
(From update of attachment 34864)
I'm not a media expert, but this patch looks wrong.  Mostly because the methods
look out of place:

One of these does not look like the other:
     virtual bool isVideo() const { return false; }
     virtual bool hasVideo() const { return false; }
+    virtual bool hasAudio() const { return player() && player()->hasAudio(); }

And again:
     virtual bool hasVideo() const = 0;
+    virtual bool hasAudio() const { return true; }

It seems maybe you're not following the design of the rest of the media
classes?

Please explain.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.