[Webkit-unassigned] [Bug 28321] New: bugzilla-tool --commit-queue needs to know how to reject mis-reviewed patches

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28321

           Summary: bugzilla-tool --commit-queue needs to know how to
                    reject mis-reviewed patches
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: New Bugs
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: eric at webkit.org


bugzilla-tool --commit-queue needs to know how to reject mis-reviewed patches

bugzilla-tool properly detects when a pach has r+ or cq+ set by someone who
does not have proper rights.  However it doesn't know how to clean up the bug
after that. It should clear flags which have been set erroneously.

What makes this tricky is the current architecture is to do that
lookups/validation inside the patch fetch function. Which is wrong.  We should
get all the patch information in one function and validate the patches
separately.  Or at least have some sort of validate=True flag which is passed
to the fetch function.

I have a partial patch on my machine, but I'll have to finish it later...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.