[Webkit-unassigned] [Bug 28308] allow down-sampling images during decoding

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28308





--- Comment #4 from Adam Treat <treat at kde.org>  2009-08-14 11:23:38 PDT ---
(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 34851 [details] [details])
> > Looking much, much better!  A few issues:
> 
> > Shift this block down below to the next 'if (m_decoder)' and you eliminate an
> > extra conditional and a nested one at that.
> 
> They are different. this 'if (m_decoder)' is reached only for the first time,
> where the below one is reached every time.

Ahh, the wonders of reading diffs.  Sorry!

> > Why is this templated?
> To be faster. template argument is kind of const values.

Ok.

> > Why do you remove this assert and change the behavior of this method even when
> > IMAGE_DECODER_DOWN_SAMPLING is disabled?
> 
> info becomes useless except in this ASSERT. I removed 'info' argument. ASSERT
> is not necessary because the caller takes care of that.

Ok, I didn't see the added ASSERT.

> > Another change that is not guarded by ENABLE(IMAGE_DECODER_DOWN_SAMPLING)
> 
> I can remove the sourceRows change. 

Thanks.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.