[Webkit-unassigned] [Bug 28303] New: [Qt] XSLT support with QtXmlPatterns

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28303

           Summary: [Qt] XSLT support with QtXmlPatterns
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: WebKit Qt
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: faw217 at gmail.com


Since the 4.5 release, QtXmlPatterns has supported XSLT 2.0 so it seems to be a
good idea for QtWebKit to use that rather than libxslt (which in fact doesn't
build now with the Qt port).

http://doc.trolltech.com/4.6-snapshot/qtxmlpatterns.html#xslt-2-0
Here is an overview of how much complete the XSLT 2.0 support in QtXmlPatterns
is. It's lacking some important features but making QtWebKit use that should
help improve it.

There is some libxml2/libxslt specific code laying around, not only in the
implementations of XSLTProcessor and XSLStyleSheet but also in e.g. Document.
For the former, we should provide our own separate implementations, for the
latter we would need some #ifdefs.

The other files/classes the Qt port doesn't need at all:
- XSLImportRule: QtXmlPatterns currently doesn't support xsl:import/xsl:include
but even when it does, it will most likely import documents internally (of
course we would need to hook that so that we can take care of security and
caching), so the XSLImportRule class we don't need.
- XSLTExtensions - this is completely a libxslt specific thing, we can't add
extra functionality to the QtXmlPatterns module so we don't need it either.
- XSLTUnicodeSort - as above, we can't extend QXmlQuery with our own sorting
functionality. If we wanted to add missing bits to the xsl:import
implementation, we would have to patch QtXmlPatterns.

The Qtish implementation of XSLStyleSheet would be pretty basic, we don't
support child stylesheets and pre-compiling stylesheets so really there is not
much what XSLStyleSheet could do apart from actually holding a stylesheet
source.

Currently I managed to achieve a result of ~35% passing layout tests. The rest
can be skipped with notes about why they fail so they can be investigated in
QtXmlPatterns. I'll post the exact results when submitting the patches.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.