[Webkit-unassigned] [Bug 28258] [Haiku] Adding RenderTheme to WebCore.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28258





--- Comment #5 from Maxime Simon <simon.maxime at gmail.com>  2009-08-14 06:23:58 PDT ---
(In reply to comment #2)
> (From update of attachment 34738 [details])
> This will error out if -wunused is on:
>  41         virtual bool supportsHover(const RenderStyle* style) const { return
> false; }

Actually, with the "-Wall" and "-Wextra" flags I didn't get the error you
specified.
But when I merged this patch with the version of RenderThemeHaiku I have in my
local branch, I got many problems. Looks like I posted the wrong patch ( an old
version ).

I noticed things like:
- "RenderThemeHaiku::function(…" in the header,
- "virtual void RenderThemeHaiku::function(…" in the cpp file,
- or even "void function(…" in the cpp code for a method of the class.

Indeed I can promptly submit another patch to avoid these stupidities. But I
should be blamed to not re-read attentively my patch before posting it.

Regards,
Maxime

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.