[Webkit-unassigned] [Bug 27551] Make it possible to build JavaScriptCore as shared library without symbol lists

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27551





--- Comment #23 from Simon Hausmann <hausmann at webkit.org>  2009-08-14 05:45:04 PDT ---
(In reply to comment #18)
> (From update of attachment 33773 [details])
> A couple of concerns and comments:
> JS_EXPORTDATA is a confusing choice of name when the majority of things being
> exported are functions.

I agree. I've uploaded an updated patch that replaces JS_EXPORTDATA with
JS_EXPORT_PRIVATE, for consistency with the existing JS_EXPORT for the public C
API.

> There are a number of places that an entire class has been marked as being
> exported even though only a single symbol is currently listed in
> JavaScriptCore.exp and JavaScriptCore.def.  ByteCodeGenerator, Parser and
> ParserArena are the three that jump out at me for this reason.

Yes, it appears a lot simpler and less cluttering to the source code to
annotate the class instead of every used function with the export macro.

> It's not clear why WEBKIT_EXPORTDATA exists.  It doesn't seem to be used
> anywhere.

Well spotted :). I've attached a patch to remove this macro alltogether.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.