[Webkit-unassigned] [Bug 28269] Inspector: Improve Cookie DataGrid to Show Hidden Data

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28269


Timothy Hatcher <timothy at hatcher.name> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34805|review?                     |review-
               Flag|                            |




--- Comment #6 from Timothy Hatcher <timothy at hatcher.name>  2009-08-13 21:14:58 PDT ---
(From update of attachment 34805)

> +    this._useFallback = typeof InspectorController.cookies() === "undefined";

This should be use typeof. We have had this talk before. :)

This does seem expensive for the case when it is implemented, sicne you get the
cookie array twice. Maybe you can store the cookies here for use later. Or
delate this until the first update is done?
> +            cookies.push(new WebInspector.Cookie(cookie.name, cookie.value, cookie.domain, cookie.path, cookie.expires, cookie.size, cookie.httpOnly, cookie.secure, cookie.session));

We don't need to use WebInspector.Cookie except for the fallback case. You can
just directly use the cookie objects in the aray.

> +                cookies.push(new WebInspector.Cookie(name, value, null, null, null, size));

Maybe we can remove WebInspector.Cookie and just make inline objects to fake a
cookie. So:

cookies.push({name: name, value: value});

> +        if (String([cookie name]) == cookieName) {

This should be written the other way so you don't convert each cookie's name to
C++.

Convert cookieName once to NSString * before the loop. Then do:

if ([[cookie name] isEqualToString:cookieNameString])

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.