[Webkit-unassigned] [Bug 15869] misalignment because of float:left of <div> tag

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=15869





--- Comment #10 from Darin Adler <darin at apple.com>  2009-08-13 13:37:34 PDT ---
(From update of attachment 34774)
> +        (WebCore::RenderBlock::getClearDelta): Changed to apply the same float
> +            avoisame logic in strict mode and in compatibility mode, which

avoisame -> avoidance

> -    // Do not allow tables to wrap in quirks or even in almost strict mode 
> -    // (ebay on the PLT, finance.yahoo.com in the real world, versiontracker.com forces even almost strict mode not to work)

Did you try these test sites?

>      int result = clearSet ? max(0, bottom - yPos) : 0;
> -    if (!result && child->avoidsFloats() && child->style()->width().isFixed() && 
> -        child->minPrefWidth() > lineWidth(yPos, false) && child->minPrefWidth() <= availableWidth() && 
> -        document()->inStrictMode())   
> -        result = max(0, floatBottom() - yPos);
> +    if (!result && child->avoidsFloats()) {
> +        int oldYPos = child->y();
> +        int oldWidth = child->width();
> +        child->setY(yPos);
> +        child->calcWidth();
> +        if (child->width() > lineWidth(yPos, false) && child->minPrefWidth() <= availableWidth())
> +            result = max(0, floatBottom() - yPos);
> +        child->setY(oldYPos);
> +        child->setWidth(oldWidth);
> +    }

I'd love to say r=me, but this may be a little out of my league. Probably needs
a Hyatt review or some other layout expert.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.