[Webkit-unassigned] [Bug 28265] New: Fix off-by-one result comparisons in media tests on Windows Debug builds
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Aug 13 10:10:56 PDT 2009
https://bugs.webkit.org/show_bug.cgi?id=28265
Summary: Fix off-by-one result comparisons in media tests on
Windows Debug builds
Product: WebKit
Version: 528+ (Nightly build)
Platform: Other
OS/Version: Mac OS X 10.5
Status: NEW
Severity: Normal
Priority: P2
Component: Tools / Tests
AssignedTo: webkit-unassigned at lists.webkit.org
ReportedBy: aroben at apple.com
CC: eric.carlson at apple.com
Adam Roben (aroben) <aroben at apple.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #34755| |review?
Flag| |
Created an attachment (id=34755)
--> (https://bugs.webkit.org/attachment.cgi?id=34755)
Patch v1
media/video-played.html seems always to time out in Windows Debug
builds. A race condition between media/video-test.js's "hang" timer and
DumpRenderTree's built-in "watchdog" timer was causing results for
media/video-played.html to be printed twice, causing all future media
tests to be compared to the previous test's results.
The fix is to get rid of video-test.js's hang timer, since it is
redundant given the existence of DRT's watchdog timer.
Reviewed by NOBODY (OOPS!).
Need a short description and bug URL (OOPS!)
* media/video-test.js: Remove the hang timer, since DRT does the same
thing.
---
2 files changed, 21 insertions(+), 8 deletions(-)
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list