[Webkit-unassigned] [Bug 28240] [Qt] Allow applications to register their own local URL scheme

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28240


Simon Hausmann <hausmann at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34709|review?                     |review-
               Flag|                            |




--- Comment #2 from Simon Hausmann <hausmann at webkit.org>  2009-08-13 08:12:19 PDT ---
(From update of attachment 34709)
I agree with the need for this API, but I have a few suggestions and comments
for the implementation:


> +/*!
> +    Allow applications to use a custome scheme instead of file: scheme,
> +    without being subjected to cross domain restrictions.
> +*/
> +void QWebSecurityOrigin::addLocalScheme(QString& scheme)

The QString argument should be a const QString &, not a QString &.


I think we may also need a function to remove a local scheme, i.e.

void removeLocalScheme(const QString &scheme);

as well as a function to return a list of all known local schemes:

QStringList QWebSecurityOrigin::localSchemes();

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.