[Webkit-unassigned] [Bug 28036] [Qt] Public API to configure the storage path for HTML5 localStorage

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28036


Simon Hausmann <hausmann at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34538|review?                     |review-
               Flag|                            |




--- Comment #17 from Simon Hausmann <hausmann at webkit.org>  2009-08-13 06:48:29 PDT ---
(From update of attachment 34538)
r- as discussed.

It would be best to have one isolated patch that

1) Fixes the naming of the enum
2) and introduces the storage path without any defaults or without enabling it
by default.

> @@ -62,7 +62,10 @@ public:
>          PrintElementBackgrounds,
>          OfflineStorageDatabaseEnabled,
>          OfflineWebApplicationCacheEnabled,
> +#ifdef QT_DEPRECATED
>          LocalStorageDatabaseEnabled,
> +#endif
> +        LocalStorageEnabled,
>          LocalContentCanAccessRemoteUrls
>      };

A slighty more backwards-compatible way of deprecating the old value would be
to use the following notation:

enum {
    ...
    LocalStorageEnabled,
#ifdef QT_DEPRECATED
    LocalStorageDatabaseEnabled = LocalStorageEnabled,
#endif

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.