[Webkit-unassigned] [Bug 23727] Implementaion of WCSS marquee extension relevant to XHML MP

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=23727


Nikolas Zimmermann <zimmermann at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |eric at webkit.org




--- Comment #34 from Nikolas Zimmermann <zimmermann at kde.org>  2009-08-13 05:54:16 PDT ---
(In reply to comment #31)
> (From update of attachment 34648 [details])
> 
>  157     if (m_layer->renderer()->document()->isXHTMLMPDocument()) {
>  158         if (m_timer.isActive() ||
> m_layer->renderer()->style()->marqueeIncrement().isZero() ||
> !m_layer->renderer()->style()->marqueeLoopCount())    
>  159             return;
>  160     } else {
>  161         if (m_timer.isActive() ||
> m_layer->renderer()->style()->marqueeIncrement().isZero())
>  162             return;
>  163     }
>  164     
> 
> I would have written that as:
> 
> 161         if (m_timer.isActive() ||
> m_layer->renderer()->style()->marqueeIncrement().isZero() ||
> (m_layer->renderer()->document()->isXHTMLMPDocument() &&
> !m_layer->renderer()->style()->marqueeLoopCount())
>  162             return;
> 
> in fact, that can seasily just be added as part of the existing if:
> 
>      if (m_timer.isActive() ||
> m_layer->renderer()->style()->marqueeIncrement().isZero()
> #if WCSS
> || (m_layer->renderer()->document()->isXHTMLMPDocument() &&
> !m_layer->renderer()->style()->marqueeLoopCount()
> #endif
> }
> 156167         return;

Okay, but that doesn't satifsy a r- in my opinion. It could be done before
landing.
Any other reason for that?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.