[Webkit-unassigned] [Bug 28235] Using QWebFrame::evaluateJavaScript does not relayout

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 13 02:02:06 PDT 2009


Simon Hausmann <hausmann at webkit.org> changed:

           What    |Removed                     |Added
  Attachment #34700|                            |review-
               Flag|                            |

--- Comment #1 from Simon Hausmann <hausmann at webkit.org>  2009-08-13 02:02:05 PDT ---
(From update of attachment 34700)
This patch is missing a ChangeLog.

I'm not convinced it's the correct fix though. Why do the other ports appear
not to need this?

For example the Mac API has stringByEvaluatingJavaScriptFromString, which can
be called to evaluate javascript and the view will be updated afterwards. (A
quick google search suggests that it works).

However I notice one important difference:

We are calling evaluate() on the ScriptController directly, whereas the mac
port calls FrameLoader::executeScript, which calls
Document::updateStyleForAllDocuments() after evaluation.

I think the correct fix involves calling executeScript instead of evaluate on
the ScriptController.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list