[Webkit-unassigned] [Bug 27734] WINCE PORT: font related changes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27734


Joe Mason <joe.mason at torchmobile.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34307|0                           |1
        is obsolete|                            |
  Attachment #34716|                            |review?
               Flag|                            |




--- Comment #30 from Joe Mason <joe.mason at torchmobile.com>  2009-08-12 22:49:08 PDT ---
Created an attachment (id=34716)
 --> (https://bugs.webkit.org/attachment.cgi?id=34716)
build fixes and minor bug fixes, with more comments

> Are you sure that min<int> will compile on other platforms?  I feel like we've
> dealt with the min/max issue on windows before in other ways.  Please grep the
> source to see how it's dealt with elsewhere.

The more common methods of dealing with the windows min/max macros won't work
here because the two parameters to min have different types (int and UChar32),
so Windows gives an error about ambiguous template parameters.  min<int> will
definitely compile on other platforms (it's just giving the template parameter
explicitly instead of letting the compiler work it out), but I changed the fix
anyway because I felt it was clearer - now it explicitly casts the UChar32 to
an int.

> This needs a why comment:
> 29 #if !PLATFORM(WINCE)
> 227230     mutable SCRIPT_CACHE m_scriptCache;
> 228231     mutable SCRIPT_FONTPROPERTIES* m_scriptFontProperties;
> 229232 #endif
> your note about it saving space in the ChangeLog is a fine comment, just put it
> in teh soruce code too.

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.