[Webkit-unassigned] [Bug 28130] [Haiku] Adding Image-specific files to WebCore.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28130





--- Comment #11 from Peter Kasting <pkasting at google.com>  2009-08-12 11:21:52 PDT ---
(In reply to comment #10)
> (In reply to comment #9)
> > > +ImageDecoder* createDecoder(const Vector<char>& data)
> > > +{
> > > +
> > > +    // JPEG
> > > +    // FIXME: Add JPEG support.
> > 
> > You're using the cross-platform decoders for all other filetypes.  Is there
> > something wrong with the cross-platform JPEG decoder that prevents you from
> > even instantiating it?
> 
> Indeed, in the default Haiku distribution libjpeg isn't available.
> Of course we could add it as dependency, but the basic way to handle
> ImageDecoder in Haiku is to use BTranslators. And we intended to use it for all
> the other filetypes as well. I may have to discuss it with Ryan.

I see.  Well, if you want to land the patch in the sort of state it's in now,
we could either #if !PLATFORM(HAIKU) (or whatever the appropriate switch is)
that block, or add some sort of ENABLE flag (which I am less in favor of).

If you want to use a completely different mechanism (I have no idea what
BTranslators are :D), we can design for that once you've got code that would
work.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.