[Webkit-unassigned] [Bug 28126] [Haiku] Adding SharedTimer to WebCore.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28126


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34663|review?                     |review-
               Flag|                            |




--- Comment #6 from Eric Seidel <eric at webkit.org>  2009-08-12 10:33:06 PDT ---
(From update of attachment 34663)
+    bigtime_t interval = fireTime - currentTime();
+
+    if (interval < 0)
+        interval = 0;
+    else
+        interval *= 1000;

Should be something like:

bigtime_t millisecondInterval = fireTime - currentTime();
bigtime_t secondInterval = std::max(0, millisecondInterval * 1000);

Important to make the variable names clear as to what they're holding.

Otherwise looks fine.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.