[Webkit-unassigned] [Bug 28076] fast/images/icon-decoding.html needs results for Qt

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 12 10:01:52 PDT 2009


--- Comment #5 from Peter Kasting <pkasting at google.com>  2009-08-12 10:01:51 PDT ---
(In reply to comment #4)
> Here is a patch for qt which corrects the layout test, but the imlementation
> should be changed higher up in QIcon and QPixmap. This is only an expected
> behaviour change, which is more compilant to the ICO file format description
> (http://www.daubnet.com/en/file-format-ico) which says:
> "For general purpose ICOs there should be at least one 32x32 image using the 16
> Windows colors."

That sentence is advisory, to note that if you only include smaller sizes,
Windows has to scale them up, and they look bad.  However, 32x32 is not a
"reference" size, and the first such entry found is not necessarily the best. 
The layout test is testing that the decoder selects the icon entries in order
of largest first, then highest bit depth first after that.  This is similar to
how Windows itself behaves, especially on newer versions like Vista and 7,
where the "typical" icon size is significantly larger than 32x32.

Note that for some applications (e.g. displaying favicons in a tab or session
history list), you probably want to be able to select a 16x16 icon.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list