[Webkit-unassigned] [Bug 27980] Give an ability to WebKit to free statically allocated pointers before quit

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 11 11:15:27 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=27980


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |darin at apple.com




--- Comment #24 from Darin Adler <darin at apple.com>  2009-08-11 11:15:23 PDT ---
(In reply to comment #23)
> I have realized why DEFINE_STATIC_LOCAL (probably DEFINE_GLOBAL is even better
> example, which use placement new to hide the destructor) defined, so the
> destructor of WTF::StaticPtr is empty of course, and never intended to do
> anything...

Please check and see what the compiler generates for this before giving a patch
that deploys it in tons of places. I'm pretty sure that an empty virtual
function will indeed generate a static destructor, although a pointless empty
one. There's a good chance it will even change the virtual pointer on the
object.

Anyway, if the technique works that's fine but it's pointless to review a patch
to deploy the technique before you've tested it!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list