[Webkit-unassigned] [Bug 25880] js tests should move into jstests subdirectory instead of resources/

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 11 10:20:14 PDT 2009


--- Comment #4 from Darin Adler <darin at apple.com>  2009-08-11 10:20:12 PDT ---
(In reply to comment #3)
> I think the first step of this bug is moving all resources/*.js files which
> aren't excluded by the list in make-js-test-wrappers into somewhere, fix all
> layout tests so that they reference the new location, and make-js-test-wrappers
> look the destination directory. Am I understanding correctly?
> Also, I'd like to know the better name for them. Maybe "js" or "scripts" ?

I think "scripts" is not a good name, because the whole point is that these are
"script tests", not just scripts. Maybe "jstests" is OK, or "js-tests" or

The way I'd do it is:

    1) Change make-js-test-wrappers to work for tests in directories either
named "resources" or the new name.

    2) Move one test with "svn mv". Run make-js-test-wrappers. Check in the new
top level .html file and the test in the new location.

    3) If everything went well after (2), then repeat (2) for all other tests.
As you say above, all the resources/*.js files that are not in the excluded

    4) Remove the support for directories named "resources" in
make-js-test-wrappers and remove the exception list as well.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list