[Webkit-unassigned] [Bug 28167] WINCE PORT: Implement ImageBuffer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28167





--- Comment #3 from Yong Li <yong.li at torchmobile.com>  2009-08-11 10:04:31 PDT ---
(In reply to comment #2)
> (From update of attachment 34519 [details])
> You mentioned in the other bug, that BufferedImage could be implemented by
> BitmapImage by implementing a BitmapImage(NativeImagePtr) constructor.  Why
> would we not want to do that?  I expect you could encounter later porting
> problems being the only port with a special BitmapImage-like-thing.

Because I think that is ugly. BitmapImage is too powerful. It is designed to
receive encoded image data, decode the data with ImageSource, display the
frames even they are just partially decoded, and animate with multiple frames
and correct time intervals...

All of these are not necessary for ImageBuffer. ImageBuffer just holds a
single-frame flat decoded buffer (or platform native image). That's why
ImageBuffer::image() returns Image* but not BitmapImage*, because BitmapImage
is much more than necessary.

So I think other ports should also do the similiar thing: using a light class
like BufferedImage. It is very simple, and doesn't required too much coding.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.