[Webkit-unassigned] [Bug 27980] Give an ability to WebKit to free statically allocated pointers before quit

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27980


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34549|review?(darin at apple.com)    |review-
               Flag|                            |




--- Comment #22 from Darin Adler <darin at apple.com>  2009-08-11 09:50:30 PDT ---
(From update of attachment 34549)
> +#include "wtf/StaticPtr.h"

Includes of wtf from WebCore use angle brackets. <wtf/StaticPtr.h>, not
"wtf/StaticPtr.h".

> +static WTF::StaticPtr<JSGlobalData> sharedInstancePtr;

This won't work with the restrictions we need to work as a Mac OS X framework.
We can't have any static destructors in our Mac OS X system frameworks as a
matter of policy to make process exit fast. No objects with destructors as
globals or statics. That's the reason for the DEFINE_STATIC_LOCAL macro.

A major reason this patch is unacceptable is that this creates many global
objects with destructors.

I didn't review further because that's a major problem with the current
version.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.