[Webkit-unassigned] [Bug 28161] Qt DumpRenderTree does not process named events.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28161


Adam Treat <treat at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34500|review?                     |review-
               Flag|                            |




--- Comment #4 from Adam Treat <treat at kde.org>  2009-08-11 07:51:58 PDT ---
(From update of attachment 34500)
This is awesome!  I imagine this will fix quite a few tests :)

A few comments:

> +    } else {
> +        qDebug() << ">>>>>>>>> keyDown" << string;

Is this necessary?

> +        // map special keycode strings used by the tests to something that works for Qt/X11
> +        if (string == "leftArrow") {

string == QLatin1String("leftArrow") I think.  r- to change.  And then I'll
land :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.