[Webkit-unassigned] [Bug 28128] [Haiku] Modifications on WebCore.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 10 20:01:12 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=28128





--- Comment #7 from Ryan Leavengood <leavengood at gmail.com>  2009-08-10 20:01:11 PDT ---
(In reply to comment #6)
> (From update of attachment 34418 [details])
> What is:
>  85         BPoint m_point;
> here?  Is it the top-left of the menu?  Is it the click-point?  Seems it needs
> a better member name.
> 
> Otherwise this change looks fine.  r- for lack of useful name or explanation
> for m_point.  If you were a committer I would just ask you to rename it to
> something when you landed it instead of r-ing.

As far as I can tell it isn't really used. It is assigned in the ContextMenu
contructor but is otherwise not used. This is probably just more cruft from the
old port that I should have helped Maxime purge :/

I'm not sure this context menu code even works at all at this point. I guess it
is a start though.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list