[Webkit-unassigned] [Bug 27511] Add WinCE specific platform/graphics files to WebCore

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27511


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |darin at apple.com




--- Comment #86 from Darin Adler <darin at apple.com>  2009-08-10 15:57:45 PDT ---
> > +    NamedNodeMap* a = element->attributes();
> > +    if (a) {
> > +        for (unsigned i = 0; i < a->length(); ++i) {
> > +            Attribute* it = a->attributeItem(i);
> > +            paramNames.append(it->name().localName().string());
> > +            paramValues.append(it->value().string());
> > +        }
> > +    }
> 
>    I guess you should remove the braces around the if, as ugly as it becomes.

If I understand you correctly, I think you're saying that you think the WebKit
coding style requires removing these braces.

That's wrong. The WebKit coding style says braces should be omitted from
one-line bodies, and this is more than one line. Perhaps you were thinking it
said to omit them from one-statement bodies?

The braces should stay.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.