[Webkit-unassigned] [Bug 28108] Tint of checkboxes/radio buttons/etc. not correctly updated on Chromium/Mac

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28108





--- Comment #9 from Jeremy Moskovich <playmobil at google.com>  2009-08-10 13:47:33 PDT ---
(From update of attachment 34510)
I'm not a reviewer, but here are my comments per dglazkov's request:

Could you add a more complete explanation here including answers to the
following questions and anything else someone looking at this code further down
the road:
* Why do we need this when Safari doesn't?
* Are controls repainted when in background?
* Comment with a summary of Avi's note.

> +static void updateNSCellControlTint(NSCell* cell, RenderObject* o) {
> +    if (o->document()->frame() && o->document()->frame()->page() &&
> +            o->document()->frame()->page()->focusController()) {
Could you split this whole check into a temp variable and then text that
variable, focusControllerIsValid or somesuch.

> +        FocusController* focusCtlr =
> +                o->document()->frame()->page()->focusController();
> +        [cell setControlTint:(focusCtlr->isActive() ?
> +                                  [NSColor currentControlTint] :
> +                                  NSClearControlTint)];
Again temp variable and lose the ?:, should make this a little easier to read.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.