[Webkit-unassigned] [Bug 27966] Race condition in the database code

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27966





--- Comment #16 from Michael Nordman <michaeln at google.com>  2009-08-10 11:56:04 PDT ---
WebKit generally avoids virtual methods where possible (a little less
indirection in a lot of places adds up). It doesn't look like there's a need
for the methods of the new class to be virtual. (also true for the other patch
you have out for review).

In looking at this again, I think there are cases where we'd expect the
m_lockAcquired flag to be true in SQLTransaction's dtor. If the DBThread is
shutdown (via requestTermination), no further transaction steps will occur
since the task queue will have been killed. So an assertion may not be valid. I
don't think that presents a problem when this interface is being used to
coordinate amoung dbfiles executing on the same dbthread but this may give
chromium grief when we're trying to use this interface to coordiate amoungst
transactions against the same dbfile system wide.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.